Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update external ros2 controller setup link #695

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Update external ros2 controller setup link #695

merged 2 commits into from
Jul 17, 2023

Conversation

mauricesvp
Copy link
Contributor

No description provided.

bmagyar
bmagyar approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Is this also revelant for the master branch?

destogl
destogl approved these changes Jul 17, 2023
View reviewed changes
doc/writing_new_controller.rst Outdated Show resolved Hide resolved
@bmagyar bmagyar added the backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. label Jul 17, 2023
@destogl destogl changed the base branch from humble to master July 17, 2023 17:43
@mergify
Copy link
Contributor

mergify bot commented Jul 17, 2023

This pull request is in conflict. Could you fix it @mauricesvp?

@bmagyar bmagyar removed the backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. label Jul 17, 2023
@destogl destogl changed the base branch from master to humble July 17, 2023 17:44
@bmagyar bmagyar merged commit dd453b2 into ros-controls:humble Jul 17, 2023
10 of 12 checks passed
@bmagyar
Copy link
Member

bmagyar commented Jul 17, 2023

@Mergifyio backport master

@mergify
Copy link
Contributor

mergify bot commented Jul 17, 2023 •
edited
Loading

backport master

✅ Backports have been created

@mergify mergify bot mentioned this pull request Jul 17, 2023
Merged
destogl added a commit that referenced this pull request Jul 17, 2023
@mergify @mauricesvp @destogl
Update external ros2 controller setup link (backport #695) (#707)
8436ed5 
* Update external ros2 controller setup link

(cherry picked from commit 9975ec1)

* Update doc/writing_new_controller.rst

(cherry picked from commit dd453b2)

---------

Co-authored-by: maurice <[email protected]>
Co-authored-by: Dr. Denis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@destogl destogl destogl approved these changes

@bmagyar bmagyar bmagyar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mauricesvp @bmagyar @destogl