Refactor new method entry point to rwh #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
reviewed
Oct 24, 2023
|
Here is what is left to do:
|
I think we should reduce the amount of example to only some basic ones and move others to integration test.
Can Windows auto resize? On macOS, it can auto resize. But I feel like we should just tell users to handle child position and size manually themselves. |
amrbashir
added a commit
to amrbashir/winit
that referenced
this pull request
Nov 6, 2023
While working on tauri-apps/wry#1041 which allows adding the webview as a child window, I noticed that when setting the webview to be transparent, the portion of the parent behind it doesn't render properly and that was because of `WS_CLIPCHILDREN`
5 tasks
amrbashir
added a commit
to tauri-apps/tao
that referenced
this pull request
Nov 6, 2023
While working on tauri-apps/wry#1041 which allows adding the webview as a child window, I noticed that when setting the webview to be transparent, the portion of the parent behind it doesn't render properly and that was because of `WS_CLIPCHILDREN`
13 tasks
wusyong
pushed a commit
to tauri-apps/tao
that referenced
this pull request
Nov 7, 2023
While working on tauri-apps/wry#1041 which allows adding the webview as a child window, I noticed that when setting the webview to be transparent, the portion of the parent behind it doesn't render properly and that was because of `WS_CLIPCHILDREN`
lucasfernog
approved these changes
Nov 7, 2023
|
@wusyong I think the overview description in README would need update as well :)
https://github.com/tauri-apps/wry/blob/dev/README.md#overview |
This was referenced Nov 9, 2023
lucasfernog
added a commit
that referenced
this pull request
Nov 12, 2023
The android_binding macro fails to compile due to the `use $wry::prelude::*;` with `expected { or *` error.
Regression from #1041 which was not released yet so I didn't add a change file.
13 tasks
amrbashir
pushed a commit
that referenced
this pull request
Nov 12, 2023
* fix(android): properly `use $wry` on android_binding macro
The android_binding macro fails to compile due to the `use $wry::prelude::*;` with `expected { or *` error.
Regression from #1041 which was not released yet so I didn't add a change file.
* use {{ }}
This was referenced Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: tauri-apps/rfcs#12
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
Other information