refactor: filemanager stack #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalenic
commented
Mar 22, 2024
Comment on lines
+102
to
+112
| NagSuppressions.addStackSuppressions( | ||
| stack, | ||
| [ | ||
| { | ||
| id: 'AwsSolutions-L1', | ||
| reason: "'AwsCustomResource' is out of date", | ||
| }, | ||
| ], | ||
| true | ||
| ); | ||
|
|
There was a problem hiding this comment.
This will probably change with #170.
victorskl
approved these changes
Mar 22, 2024
| lambdaSecurityGroupName: props.lambdaSecurityGroupName, | ||
| }); | ||
| } | ||
| this.microserviceStackArray.push(this.createFilemanager(props.filemanagerConfig)); |
There was a problem hiding this comment.
Woo ho ho! Welcome to the nag club! 🤭
| this.queue = new Queue(this, 'Queue', { | ||
| queueName: props.queueName, | ||
| enforceSSL: true, |
williamputraintan
approved these changes
Mar 22, 2024
This was referenced Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #169
Changes
RDS_IAMas part of postgres manager. Note, currently this still uses the master RDS credentials. Both these points will be addressed in filemanager: link up filemanager with postgres database manager #138.CdkResourceInvoketocomponents.