Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra -headerpad linker argument #4347

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Remove extra -headerpad linker argument #4347

merged 1 commit into from
Jul 16, 2024

Conversation

adamnovak
Copy link
Member

Changelog Entry

To be copied to the draft changelog by merger:

  • vg mac builds no longer pass -headerpad without an argument to the linker.

Description

According to the Clang 15 man page, -headerpad needs a size argument:

-headerpad size
        Specifies the minimum space for future expansion of the load commands.  Only useful
        if intend to run install_name_tool to alter the load commands later. Size is a
        hexadecimal number.

-headerpad_max_install_names
        Automatically adds space for future expansion of load commands such that all paths
        could expand to MAXPATHLEN.  Only useful if intend to run install_name_tool to alter
        the load commands later.

I don't think it does anything we need that -headerpad_max_install_names doesn't do. And it is causing build failures for some people (see https://www.biostars.org/p/9598655/) because it doesn't have an argument.

According to the Clang 15 man page it needs a size argument, and I don't think it does anything we need that `-headerpad_max_install_names` doesn't do. And it is causing build failures for some people (see <https://www.biostars.org/p/9598655/>) because it doesn't have an argument.
@adamnovak
Copy link
Member Author

This might be needed to actually fix #4257; we never worked out how to reproduce it, so it's hard to tell.

@adamnovak adamnovak merged commit c1bcdef into master Jul 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant