Sort minimizers by score in Giraffe single-end mode #4351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently in 40bf613 I meant to keep the minimizers sorted by score in single-end mapping mode, but when #3810 actually merged it changed the order that find_minimizers returns results in to read order and added a score sort to the paired-end non-chaining codepath but not the single-end non-chaining codepath. This should restore the vg 1.44.0 behavior of taking or not taking identical minimizers all across the read, and also of prioritizing minimizers to take by score, in single-end mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
vg giraffein non-chaining single-end mode will again prioritize minimizers the same way as in paired-end modeDescription
Apparently in 40bf613 I meant to keep the minimizers sorted by score in single-end mapping mode, but when #3810 actually merged it changed the order that find_minimizers returns results in to read order and added a score sort to the paired-end non-chaining codepath but not the single-end non-chaining codepath.
This should restore the vg 1.44.0 behavior of taking or not taking identical minimizers all across the read, and also of prioritizing minimizers to take by score, in single-end mode.