Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort minimizers by score in Giraffe single-end mode #4351

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Sort minimizers by score in Giraffe single-end mode #4351

merged 1 commit into from
Jul 19, 2024

Commits on Jul 17, 2024

  1. Sort minimizers by score in Giraffe single-end mode 

    Apparently in 40bf613 I meant to keep the minimizers sorted by score in single-end mapping mode, but when #3810 actually merged it changed the order that find_minimizers returns results in to read order and added a score sort to the paired-end non-chaining codepath but not the single-end non-chaining codepath.

This should restore the vg 1.44.0 behavior of taking or not taking identical minimizers all across the read, and also of prioritizing minimizers to take by score, in single-end mode.
    @adamnovak
    adamnovak authored Jul 17, 2024
    1 Configuration menu
    Copy the full SHA
    a0e8e8a View commit details
    Browse the repository at this point in the history