[android] Support configuring maximum number of samples per write to SbPlayer from webapp #3325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borongc
force-pushed
the
android_multiple_write
branch
from
fce0e38
to
3c7baf8
Compare
borongc
force-pushed
the
android_multiple_write
branch
from
3c7baf8
to
024a16a
Compare
xiaomings
reviewed
May 22, 2024
borongc
force-pushed
the
android_multiple_write
branch
5 times, most recently
from
2f3f9fd
to
acff397
Compare
borongc
changed the title
borongc
force-pushed
the
android_multiple_write
branch
4 times, most recently
from
6eb3b09
to
305ec1a
Compare
borongc
changed the title
borongc
force-pushed
the
android_multiple_write
branch
3 times, most recently
from
ee4ac0a
to
a52d84d
Compare
borongc
force-pushed
the
android_multiple_write
branch
from
a52d84d
to
4d44802
Compare
…SbPlayer from webapp 1. Support maximum number of samples per write configuration from the h5vcc setting. 2. Enable this feature by the h5vcc settings of "EnableBatchedSampleWrite" and a positive value for "PlayerConfiguration.SetMaximumNumberOfSamplesPerWrite". b/227837774
borongc
force-pushed
the
android_multiple_write
branch
from
4d44802
to
de9785d
Compare
kaidokert
pushed a commit
to borongc/cobalt
that referenced
this pull request
Jun 14, 2024
This PR (youtube#3325) changes SbPlayerGetMaximumNumberOfSamplesPerWrite() to 256 on ATV, but current testing files for SbPlayerWriteSampleTest.WriteSingleBatch tests are not long enough for the modification. Disable the tests and should be re-enabled once it fixes. b/347097484
borongc
added a commit
that referenced
this pull request
Jun 14, 2024
This PR (#3325) changes SbPlayerGetMaximumNumberOfSamplesPerWrite() to 256 on ATV as Cobalt supports multiple samples per write to SbPlayer (b/227837774), but current testing files for SbPlayerWriteSampleTest.WriteSingleBatch tests are not long enough for the modification. Disable the tests and should be re-enabled once it fixes. b/347097484
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Jun 14, 2024
This PR (#3325) changes SbPlayerGetMaximumNumberOfSamplesPerWrite() to 256 on ATV as Cobalt supports multiple samples per write to SbPlayer (b/227837774), but current testing files for SbPlayerWriteSampleTest.WriteSingleBatch tests are not long enough for the modification. Disable the tests and should be re-enabled once it fixes. b/347097484 (cherry picked from commit cc76a9c)
borongc
added a commit
that referenced
this pull request
Jun 14, 2024
#3567) Refer to the original PR: #3564 This PR (#3325) changes SbPlayerGetMaximumNumberOfSamplesPerWrite() to 256 on ATV as Cobalt supports multiple samples per write to SbPlayer (b/227837774), but current testing files for SbPlayerWriteSampleTest.WriteSingleBatch tests are not long enough for the modification. Disable the tests and should be re-enabled once it fixes. b/347097484 Co-authored-by: Bo-Rong Chen <[email protected]>
borongc
added a commit
that referenced
this pull request
Jun 14, 2024
…SbPlayer from webapp (#3325) The PR (#3271) limits the maximum number of samples per write to SbPlayer with audio write ahead. This PR refactors the existing H5VCC flag from "EnableBatchedSampleWrite" to "AudioBatchedSampleWrite" that allows configuring maximum number of samples per write to SbPlayer from webapp. 1. When "AudioBatchedSampleWrite=1" or not set, Cobalt uses the default number of samples per write (i.e., 1) to SbPlayer. 2. When "AudioBatchedSampleWrite=n", where n > 1, Cobalt uses the number of samples per write estimated by GetEstimatedMaxBuffers() to SbPlayer. This PR also changes SbPlayerGetMaximumNumberOfSamplesPerWrite() to 256 on Android TV. Note in case 2, the number of samples per write is in the range of [1, min(SbPlayerGetMaximumNumberOfSamplesPerWrite(), AudioBatchedSampleWrite)]. For other platforms except Android, SbPlayerGetMaximumNumberOfSamplesPerWrite should return 1. b/227837774 Test-On-Device: true (cherry picked from commit ed62b35)
xiaomings
reviewed
Jun 14, 2024
kaidokert
pushed a commit
that referenced
this pull request
Jun 14, 2024
… samples per write to SbPlayer from webapp (#3561) Refer to the original PR: #3325 The PR (#3271) limits the maximum number of samples per write to SbPlayer with audio write ahead. This PR refactors the existing H5VCC flag from "EnableBatchedSampleWrite" to "AudioBatchedSampleWrite" that allows configuring maximum number of samples per write to SbPlayer from webapp. 1. When "AudioBatchedSampleWrite=1" or not set, Cobalt uses the default number of samples per write (i.e., 1) to SbPlayer. 2. When "AudioBatchedSampleWrite=n", where n > 1, Cobalt uses the number of samples per write estimated by GetEstimatedMaxBuffers() to SbPlayer. This PR also changes SbPlayerGetMaximumNumberOfSamplesPerWrite() to 256 on Android TV. Note in case 2, the number of samples per write is in the range of [1, min(SbPlayerGetMaximumNumberOfSamplesPerWrite(), AudioBatchedSampleWrite)]. For other platforms except Android, SbPlayerGetMaximumNumberOfSamplesPerWrite should return 1. b/227837774 Test-On-Device: true Co-authored-by: Bo-Rong Chen <[email protected]>
borongc
added a commit
to borongc/cobalt
that referenced
this pull request
Jun 14, 2024
Rename AudioBatchedSampleWrite to MaxAudioSamplesPerWrite followed by PR (youtube#3325). b/227837774
borongc
added a commit
to borongc/cobalt
that referenced
this pull request
Jun 14, 2024
Rename AudioBatchedSampleWrite to MaxAudioSamplesPerWrite followed by PR (youtube#3325). b/227837774
borongc
added a commit
to borongc/cobalt
that referenced
this pull request
Jun 15, 2024
Rename AudioBatchedSampleWrite to MaxAudioSamplesPerWrite followed by PR (youtube#3325). b/227837774
borongc
added a commit
to borongc/cobalt
that referenced
this pull request
Jun 17, 2024
Rename AudioBatchedSampleWrite to MaxAudioSamplesPerWrite followed by PR (youtube#3325). b/227837774
borongc
added a commit
to borongc/cobalt
that referenced
this pull request
Jun 17, 2024
Rename AudioBatchedSampleWrite to MaxAudioSamplesPerWrite followed by PR (youtube#3325). b/227837774
borongc
added a commit
to borongc/cobalt
that referenced
this pull request
Jun 17, 2024
Rename AudioBatchedSampleWrite to MaxAudioSamplesPerWrite followed by PR (youtube#3325). b/227837774
borongc
added a commit
to borongc/cobalt
that referenced
this pull request
Jun 17, 2024
This PR (youtube#3325) changes SbPlayerGetMaximumNumberOfSamplesPerWrite() to 256 on ATV as Cobalt supports multiple samples per write to SbPlayer (b/227837774), but current testing files for SbPlayerWriteSampleTest.WriteSingleBatch tests are not long enough for the modification. 1. Set upper bounds for WriteSingleBatch tests (15 audio samples per write, 60 video samples per write) when SbPlayerGetMaximumNumberOfSamplesPerWrite() > 1. 2. Revisit the upper bounds when the requirement is changed (b/347728473). b/347097484 Test-On-Device: true
borongc
added a commit
to borongc/cobalt
that referenced
this pull request
Jun 17, 2024
This PR (youtube#3325) changes SbPlayerGetMaximumNumberOfSamplesPerWrite() to 256 on ATV as Cobalt supports multiple samples per write to SbPlayer (b/227837774), but current testing files for SbPlayerWriteSampleTest.WriteSingleBatch tests are not long enough for the modification. 1. Set upper bounds for WriteSingleBatch tests (15 audio samples per write, 60 video samples per write) when SbPlayerGetMaximumNumberOfSamplesPerWrite() > 1. 2. Revisit the upper bounds when the requirement is changed (b/347728473). b/347097484 Test-On-Device: true
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Jun 17, 2024
borongc
added a commit
that referenced
this pull request
Jun 17, 2024
…axAudioSamplesPerWrite (#3585) Refer to the original PR: #3568 Rename AudioBatchedSampleWrite to MaxAudioSamplesPerWrite followed by PR (#3325). b/227837774 Co-authored-by: Bo-Rong Chen <[email protected]>
borongc
added a commit
to borongc/cobalt
that referenced
this pull request
Jun 17, 2024
This PR (youtube#3325) changes SbPlayerGetMaximumNumberOfSamplesPerWrite() to 256 on ATV as Cobalt supports multiple samples per write to SbPlayer (b/227837774), but current testing files for SbPlayerWriteSampleTest.WriteSingleBatch tests are not long enough for the modification. 1. Set upper bounds for WriteSingleBatch tests (15 audio samples per write, 60 video samples per write) when SbPlayerGetMaximumNumberOfSamplesPerWrite() > 1. 2. Revisit the upper bounds when the requirement is changed (b/347728473). b/347097484 Test-On-Device: true
borongc
added a commit
to borongc/cobalt
that referenced
this pull request
Jun 17, 2024
This PR (youtube#3325) changes SbPlayerGetMaximumNumberOfSamplesPerWrite() to 256 on ATV as Cobalt supports multiple samples per write to SbPlayer (b/227837774), but current testing files for SbPlayerWriteSampleTest.WriteSingleBatch tests are not long enough for the modification. 1. Set upper bounds for WriteSingleBatch tests (15 audio samples per write, 60 video samples per write) when SbPlayerGetMaximumNumberOfSamplesPerWrite() > 1. 2. Revisit the upper bounds when the requirement is changed (b/347728473). b/347097484 Test-On-Device: true
borongc
added a commit
to borongc/cobalt
that referenced
this pull request
Jun 18, 2024
This PR (youtube#3325) changes SbPlayerGetMaximumNumberOfSamplesPerWrite() to 256 on ATV as Cobalt supports multiple samples per write to SbPlayer (b/227837774), but current testing files for SbPlayerWriteSampleTest.WriteSingleBatch tests are not long enough for the modification. 1. Set upper bounds for WriteSingleBatch tests (15 audio samples per write, 60 video samples per write) when SbPlayerGetMaximumNumberOfSamplesPerWrite() > 1. 2. Revisit the upper bounds when the requirement is changed (b/347728473). b/347097484 Test-On-Device: true
borongc
added a commit
that referenced
this pull request
Jun 18, 2024
This PR (#3325) changes SbPlayerGetMaximumNumberOfSamplesPerWrite() to 256 on ATV as Cobalt supports multiple samples per write to SbPlayer (b/227837774), but current testing files for SbPlayerWriteSampleTest.WriteSingleBatch tests are not long enough for the modification. 1. Set upper bounds for WriteSingleBatch tests (15 audio samples per write, 60 video samples per write) when SbPlayerGetMaximumNumberOfSamplesPerWrite() > 1. 2. We should revisit the upper bounds when the requirement is changed (b/347728473). b/347097484 Test-On-Device: true
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Jun 18, 2024
This PR (#3325) changes SbPlayerGetMaximumNumberOfSamplesPerWrite() to 256 on ATV as Cobalt supports multiple samples per write to SbPlayer (b/227837774), but current testing files for SbPlayerWriteSampleTest.WriteSingleBatch tests are not long enough for the modification. 1. Set upper bounds for WriteSingleBatch tests (15 audio samples per write, 60 video samples per write) when SbPlayerGetMaximumNumberOfSamplesPerWrite() > 1. 2. We should revisit the upper bounds when the requirement is changed (b/347728473). b/347097484 Test-On-Device: true (cherry picked from commit 5115448)
borongc
added a commit
that referenced
this pull request
Jun 18, 2024
…3590) Refer to the original PR: #3584 This PR (#3325) changes SbPlayerGetMaximumNumberOfSamplesPerWrite() to 256 on ATV as Cobalt supports multiple samples per write to SbPlayer (b/227837774), but current testing files for SbPlayerWriteSampleTest.WriteSingleBatch tests are not long enough for the modification. 1. Set upper bounds for WriteSingleBatch tests (15 audio samples per write, 60 video samples per write) when SbPlayerGetMaximumNumberOfSamplesPerWrite() > 1. 2. We should revisit the upper bounds when the requirement is changed (b/347728473). b/347097484 Test-On-Device: true Co-authored-by: Bo-Rong Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR (#3271) limits the maximum number of samples per write to SbPlayer with audio write ahead. This PR refactors the existing H5VCC flag from "EnableBatchedSampleWrite" to "AudioBatchedSampleWrite" that allows configuring maximum number of samples per write to SbPlayer from webapp.
This PR also changes SbPlayerGetMaximumNumberOfSamplesPerWrite() to 256 on Android TV. Note in case 2, the number of samples per write is in the range of [1, min(SbPlayerGetMaximumNumberOfSamplesPerWrite(), AudioBatchedSampleWrite)]. For other platforms except Android, SbPlayerGetMaximumNumberOfSamplesPerWrite should return 1.
b/227837774
Test-On-Device: true