Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tech: Move DetailsList to ProductCard folder #4698

Merged
merged 2 commits into from
Sep 19, 2024
Merged

tech: Move DetailsList to ProductCard folder #4698

merged 2 commits into from
Sep 19, 2024

Conversation

Youakeem
Copy link
Contributor

@Youakeem Youakeem commented Sep 13, 2024 •
edited
Loading

Describe your changes

Subj

Justify why they are needed

Co-locate ProductDetails components

Checklist before requesting a review

  • I have performed a self-review of my code

@vercel Vercel
Copy link

vercel bot commented Sep 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hedvig-dot-com ✅ Ready (Inspect) Visit Preview Sep 19, 2024 11:08am

This was referenced Sep 13, 2024
Closed
Merged
@Youakeem Graphite App
Copy link
Contributor Author

Youakeem commented Sep 13, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Youakeem and the rest of your teammates on Graphite Graphite

This was referenced Sep 13, 2024
Merged
Merged
Merged
@Youakeem Youakeem force-pushed the 09-13-create_button_outline_variant branch from 005e6e9 to 856a795 Compare September 16, 2024 09:34
This was referenced Sep 16, 2024
Merged
Merged
Merged
Merged
@Youakeem Youakeem force-pushed the 09-13-move_detailslist_to_productcard_folder branch from 7d41c8f to b5198a3 Compare September 16, 2024 09:34
This was referenced Sep 16, 2024
Merged
Merged
Merged
Merged
@Youakeem Youakeem force-pushed the 09-13-create_button_outline_variant branch from 856a795 to 7ee5cf8 Compare September 16, 2024 09:54
@Youakeem Youakeem force-pushed the 09-13-move_detailslist_to_productcard_folder branch from b5198a3 to 00e406f Compare September 16, 2024 09:54
@Youakeem Youakeem changed the title Move DetailsList to ProductCard folder tech: Move DetailsList to ProductCard folder Sep 16, 2024
@Youakeem Youakeem marked this pull request as ready for review September 16, 2024 12:23
@Youakeem Youakeem requested a review from a team as a code owner September 16, 2024 12:23
@Youakeem Youakeem force-pushed the 09-13-create_button_outline_variant branch from 7ee5cf8 to c2f5fca Compare September 16, 2024 15:24
@Youakeem Youakeem force-pushed the 09-13-move_detailslist_to_productcard_folder branch from 2ca1b1b to 5e63711 Compare September 16, 2024 15:24
@Youakeem Youakeem force-pushed the 09-13-create_button_outline_variant branch from c2f5fca to 6e21b37 Compare September 16, 2024 15:36
@Youakeem Youakeem force-pushed the 09-13-move_detailslist_to_productcard_folder branch from 5e63711 to a3161ad Compare September 16, 2024 15:36
@Youakeem Youakeem force-pushed the 09-13-create_button_outline_variant branch from 6e21b37 to da0dc01 Compare September 16, 2024 15:46
@Youakeem Youakeem force-pushed the 09-13-move_detailslist_to_productcard_folder branch from 681159e to dc8fe1e Compare September 18, 2024 10:58
@Youakeem Youakeem force-pushed the 09-13-create_button_outline_variant branch from 60570d4 to 7e73fb8 Compare September 18, 2024 11:52
@Youakeem Youakeem force-pushed the 09-13-move_detailslist_to_productcard_folder branch from dc8fe1e to f48cc7e Compare September 18, 2024 11:52
@Youakeem Youakeem force-pushed the 09-13-create_button_outline_variant branch from 7e73fb8 to 77ebfc9 Compare September 18, 2024 11:58
@Youakeem Youakeem force-pushed the 09-13-move_detailslist_to_productcard_folder branch from f48cc7e to aec323f Compare September 18, 2024 11:58
This was referenced Sep 18, 2024
Merged
Merged
Merged
Merged
@Youakeem Youakeem force-pushed the 09-13-create_button_outline_variant branch from 77ebfc9 to 46d706a Compare September 18, 2024 15:17
@Youakeem Youakeem force-pushed the 09-13-move_detailslist_to_productcard_folder branch from aec323f to a4a0534 Compare September 18, 2024 15:17
@Youakeem Youakeem force-pushed the 09-13-create_button_outline_variant branch from 46d706a to 389a3d8 Compare September 18, 2024 15:20
@Youakeem Youakeem force-pushed the 09-13-move_detailslist_to_productcard_folder branch from a4a0534 to 5b44634 Compare September 18, 2024 15:20
@Youakeem Graphite App
Copy link
Contributor Author

Youakeem commented Sep 19, 2024 •
edited
Loading

Merge activity

  • Sep 19, 3:16 AM EDT: @Youakeem started a stack merge that includes this pull request via Graphite.
  • Sep 19, 7:02 AM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 19, 7:09 AM EDT: @Youakeem merged this pull request with Graphite.

@Youakeem Youakeem force-pushed the 09-13-create_button_outline_variant branch from 389a3d8 to 1463e1f Compare September 19, 2024 10:07
@Youakeem Youakeem force-pushed the 09-13-move_detailslist_to_productcard_folder branch from 5b44634 to aba7eaf Compare September 19, 2024 10:07
This was referenced Sep 19, 2024
Merged
Merged
@Youakeem Youakeem changed the base branch from 09-13-create_button_outline_variant to graphite-base/4698 September 19, 2024 10:48
@Youakeem Youakeem changed the base branch from graphite-base/4698 to main September 19, 2024 11:00
@Youakeem Youakeem force-pushed the 09-13-move_detailslist_to_productcard_folder branch from aba7eaf to 3f4fbe4 Compare September 19, 2024 11:01
@Youakeem Youakeem merged commit 56c3b6b into main Sep 19, 2024
5 checks passed
@Youakeem Youakeem deleted the 09-13-move_detailslist_to_productcard_folder branch September 19, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alebedev alebedev alebedev approved these changes

@gustaveen gustaveen gustaveen approved these changes

@guilhermespopolin guilhermespopolin guilhermespopolin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Youakeem @alebedev @gustaveen @guilhermespopolin