Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tech: Add IconButton component #4706

Merged
merged 3 commits into from
Sep 19, 2024
Merged

tech: Add IconButton component #4706

merged 3 commits into from
Sep 19, 2024

Conversation

Youakeem
Copy link
Contributor

@Youakeem Youakeem commented Sep 16, 2024 •
edited
Loading

Describe your changes

Small wrapper around the Button component for icon only buttons similar to the one we have in Hope.

Justify why they are needed

Reuse styles needed for icon buttons.

Checklist before requesting a review

  • I have performed a self-review of my code

@vercel Vercel
Copy link

vercel bot commented Sep 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hedvig-dot-com ✅ Ready (Inspect) Visit Preview Sep 19, 2024 8:03am

@Youakeem Graphite App
Copy link
Contributor Author

Youakeem commented Sep 16, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Youakeem and the rest of your teammates on Graphite Graphite

This was referenced Sep 16, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@Youakeem Youakeem changed the title Add IconButton component tech: Add IconButton component Sep 16, 2024
@Youakeem Youakeem marked this pull request as ready for review September 16, 2024 10:04
@Youakeem Youakeem requested a review from a team as a code owner September 16, 2024 10:04
@Youakeem Youakeem force-pushed the tech-icon-button-component branch 3 times, most recently from 9a1d580 to c840a27 Compare September 16, 2024 15:51
This was referenced Sep 18, 2024
Merged
Merged
Merged
Merged
@Youakeem Graphite App
Copy link
Contributor Author

Youakeem commented Sep 19, 2024 •
edited
Loading

Merge activity

  • Sep 19, 3:16 AM EDT: @Youakeem started a stack merge that includes this pull request via Graphite.
  • Sep 19, 3:54 AM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 19, 4:04 AM EDT: @Youakeem merged this pull request with Graphite.

@Youakeem Youakeem changed the base branch from tech-card-component to graphite-base/4706 September 19, 2024 07:41
@Youakeem Youakeem changed the base branch from graphite-base/4706 to main September 19, 2024 07:51
@Youakeem Youakeem merged commit 1decb8c into main Sep 19, 2024
5 checks passed
@Youakeem Youakeem deleted the tech-icon-button-component branch September 19, 2024 08:04
This was referenced Sep 19, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alebedev alebedev alebedev approved these changes

@gustaveen gustaveen gustaveen left review comments

@guilhermespopolin guilhermespopolin guilhermespopolin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Youakeem @alebedev @gustaveen @guilhermespopolin