Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tech: add secondary Card variant #4709

Merged
merged 3 commits into from
Sep 19, 2024
Merged

tech: add secondary Card variant #4709

merged 3 commits into from
Sep 19, 2024

Conversation

Youakeem
Copy link
Contributor

@Youakeem Youakeem commented Sep 16, 2024 •
edited
Loading

Describe your changes

  • Add the secondary card variant
  • Move the Card aside from header level to card level

Screenshot 2024-09-16 at 13.18.28.png

Justify why they are needed

Align with Figma

Checklist before requesting a review

  • I have performed a self-review of my code

@vercel Vercel
Copy link

vercel bot commented Sep 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hedvig-dot-com ✅ Ready (Inspect) Visit Preview Sep 19, 2024 8:39am

This was referenced Sep 16, 2024
Merged
Merged
Merged
Merged
Merged
@Youakeem Graphite App
Copy link
Contributor Author

Youakeem commented Sep 16, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Youakeem and the rest of your teammates on Graphite Graphite

This was referenced Sep 16, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@Youakeem Youakeem changed the title Add secondary Card variant tech: add secondary Card variant Sep 16, 2024
@Youakeem Youakeem marked this pull request as ready for review September 16, 2024 11:19
@Youakeem Youakeem requested a review from a team as a code owner September 16, 2024 11:19
@Youakeem Youakeem mentioned this pull request Sep 18, 2024
Merged
1 task
This was referenced Sep 18, 2024
Merged
Merged
Merged
Merged
@Youakeem Graphite App
Copy link
Contributor Author

Youakeem commented Sep 19, 2024 •
edited
Loading

Merge activity

  • Sep 19, 3:16 AM EDT: @Youakeem started a stack merge that includes this pull request via Graphite.
  • Sep 19, 4:29 AM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 19, 4:40 AM EDT: @Youakeem merged this pull request with Graphite.

@Youakeem Youakeem changed the base branch from tech-tooltip-ui-component to graphite-base/4709 September 19, 2024 08:18
@Youakeem Youakeem changed the base branch from graphite-base/4709 to main September 19, 2024 08:27
@Youakeem Youakeem merged commit 6b54fb5 into main Sep 19, 2024
5 checks passed
@Youakeem Youakeem deleted the tech-secondary-card branch September 19, 2024 08:40
This was referenced Sep 19, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilhermespopolin guilhermespopolin guilhermespopolin approved these changes

@alebedev alebedev alebedev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Youakeem @alebedev @guilhermespopolin