Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tech: Create Default ProductCard story #4700

Merged
merged 4 commits into from
Sep 19, 2024
Merged

tech: Create Default ProductCard story #4700

merged 4 commits into from
Sep 19, 2024

Conversation

Youakeem
Copy link
Contributor

@Youakeem Youakeem commented Sep 13, 2024 •
edited
Loading

Describe your changes

Compose the default ProductCard component out of different building blocks

🎥 Video uploaded on Graphite:

Justify why they are needed

New ProductCard components
https://www.figma.com/design/5kmmDdh6StpXzbEfr7WevV/Hedvig-UI-Kit?node-id=16269-14623&t=KfZGhlcQELqgimtF-1

Checklist before requesting a review

  • I have performed a self-review of my code

@vercel Vercel
Copy link

vercel bot commented Sep 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hedvig-dot-com ✅ Ready (Inspect) Visit Preview Sep 19, 2024 11:36am

This was referenced Sep 13, 2024
Closed
Merged
Merged
@Youakeem Graphite App
Copy link
Contributor Author

Youakeem commented Sep 13, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Youakeem and the rest of your teammates on Graphite Graphite

This was referenced Sep 13, 2024
Merged
Merged
@vercel vercel bot requested a deployment to Preview September 13, 2024 17:57 Abandoned
This was referenced Sep 16, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@Youakeem Youakeem force-pushed the 09-13-update_price_component_to_vanilla-extract branch from 9c29521 to 7c1a593 Compare September 16, 2024 09:34
@Youakeem Youakeem force-pushed the 09-13-create_default_productcard_story branch from 6de4561 to 1cfa5f3 Compare September 16, 2024 09:34
@Youakeem Youakeem force-pushed the 09-13-update_price_component_to_vanilla-extract branch from 7c1a593 to 0845705 Compare September 16, 2024 09:54
@Youakeem Youakeem force-pushed the 09-13-create_default_productcard_story branch from 1cfa5f3 to d9b0e0b Compare September 16, 2024 09:54
@Youakeem Youakeem force-pushed the 09-13-update_price_component_to_vanilla-extract branch from 0845705 to be265e2 Compare September 16, 2024 12:01
@Youakeem Youakeem force-pushed the 09-13-create_default_productcard_story branch from d9b0e0b to b493db0 Compare September 16, 2024 12:01
@Youakeem Youakeem changed the title Create Default ProductCard story tech: Create Default ProductCard story Sep 16, 2024
@Youakeem Youakeem marked this pull request as ready for review September 16, 2024 12:43
@Youakeem Youakeem requested a review from a team as a code owner September 16, 2024 12:43
@Youakeem Youakeem force-pushed the 09-13-update_price_component_to_vanilla-extract branch from be265e2 to 41d6524 Compare September 16, 2024 15:24
@Youakeem Youakeem force-pushed the 09-13-update_price_component_to_vanilla-extract branch from de24268 to 9467132 Compare September 18, 2024 11:52
@Youakeem Youakeem force-pushed the 09-13-create_default_productcard_story branch from 6efbab3 to b977bc5 Compare September 18, 2024 11:52
@Youakeem Youakeem force-pushed the 09-13-update_price_component_to_vanilla-extract branch from 9467132 to c949438 Compare September 18, 2024 11:58
@Youakeem Youakeem force-pushed the 09-13-create_default_productcard_story branch from b977bc5 to 64bf17f Compare September 18, 2024 11:58
This was referenced Sep 18, 2024
Merged
Merged
Merged
Merged
@Youakeem Youakeem force-pushed the 09-13-update_price_component_to_vanilla-extract branch from c949438 to 0f188a3 Compare September 18, 2024 15:17
@Youakeem Youakeem force-pushed the 09-13-create_default_productcard_story branch from 64bf17f to 012da09 Compare September 18, 2024 15:17
@Youakeem Youakeem force-pushed the 09-13-update_price_component_to_vanilla-extract branch from 0f188a3 to 571bc67 Compare September 18, 2024 15:20
@Youakeem Youakeem force-pushed the 09-13-create_default_productcard_story branch from 012da09 to a40af53 Compare September 18, 2024 15:20
@Youakeem Graphite App
Copy link
Contributor Author

Youakeem commented Sep 19, 2024 •
edited
Loading

Merge activity

  • Sep 19, 3:16 AM EDT: @Youakeem started a stack merge that includes this pull request via Graphite.
  • Sep 19, 7:32 AM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 19, 7:36 AM EDT: @Youakeem merged this pull request with Graphite.

@Youakeem Youakeem force-pushed the 09-13-update_price_component_to_vanilla-extract branch from 571bc67 to ddc6788 Compare September 19, 2024 10:07
@Youakeem Youakeem force-pushed the 09-13-create_default_productcard_story branch from a40af53 to 88f50a5 Compare September 19, 2024 10:07
This was referenced Sep 19, 2024
Merged
Merged
@Youakeem Youakeem changed the base branch from 09-13-update_price_component_to_vanilla-extract to graphite-base/4700 September 19, 2024 11:10
@Youakeem Youakeem changed the base branch from graphite-base/4700 to main September 19, 2024 11:30
@Youakeem Youakeem force-pushed the 09-13-create_default_productcard_story branch from 88f50a5 to 4ae8304 Compare September 19, 2024 11:31
@Youakeem Youakeem merged commit 011dc32 into main Sep 19, 2024
5 checks passed
@Youakeem Youakeem deleted the 09-13-create_default_productcard_story branch September 19, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alebedev alebedev alebedev left review comments

@guilhermespopolin guilhermespopolin guilhermespopolin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Youakeem @alebedev @guilhermespopolin