Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tech: Rename ProductCard to ProductGridItem #4703

Merged
merged 3 commits into from
Sep 19, 2024
Merged

tech: Rename ProductCard to ProductGridItem #4703

merged 3 commits into from
Sep 19, 2024

Conversation

Youakeem
Copy link
Contributor

@Youakeem Youakeem commented Sep 16, 2024 •
edited
Loading

Describe your changes

Subj

Justify why they are needed

ProductGridItem is the CMS version of a product card while ProductCard will be used in the purchase flow.

  • I have performed a self-review of my code

@vercel Vercel
Copy link

vercel bot commented Sep 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hedvig-dot-com ✅ Ready (Inspect) Visit Preview Sep 19, 2024 7:23am

@Youakeem Graphite App
Copy link
Contributor Author

Youakeem commented Sep 16, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Youakeem and the rest of your teammates on Graphite Graphite

This was referenced Sep 16, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@Youakeem Youakeem changed the title Update Storybook tech: Rename ProductCard to ProductGridItem Sep 16, 2024
@Youakeem Youakeem marked this pull request as ready for review September 16, 2024 09:37
@Youakeem Youakeem requested a review from a team as a code owner September 16, 2024 09:37
@Youakeem Youakeem force-pushed the tech-rename-product-card-product-grid-item branch from 06315f5 to e33851e Compare September 16, 2024 09:53
gustaveen
gustaveen approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@gustaveen gustaveen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@Youakeem Youakeem force-pushed the tech-rename-product-card-product-grid-item branch from e33851e to c9072f1 Compare September 17, 2024 08:01
@Youakeem Youakeem mentioned this pull request Sep 17, 2024
Closed
1 task
@Youakeem Youakeem force-pushed the tech-rename-product-card-product-grid-item branch from c9072f1 to 4e20ebf Compare September 17, 2024 08:40
guilhermespopolin
guilhermespopolin approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@guilhermespopolin guilhermespopolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one :)

@Youakeem Youakeem force-pushed the tech-rename-product-card-product-grid-item branch from 4e20ebf to 37a54e3 Compare September 17, 2024 11:45
@Youakeem Youakeem force-pushed the tech-rename-product-card-product-grid-item branch from 37a54e3 to 56a27d9 Compare September 17, 2024 13:11
@Youakeem Youakeem mentioned this pull request Sep 17, 2024
Merged
1 task
This was referenced Sep 18, 2024
Merged
Merged
Merged
@Youakeem Youakeem force-pushed the tech-rename-product-card-product-grid-item branch from 56a27d9 to 8e2a84e Compare September 18, 2024 10:57
@Youakeem Youakeem force-pushed the tech-rename-product-card-product-grid-item branch from 8e2a84e to e5d0954 Compare September 18, 2024 11:51
@Youakeem Youakeem force-pushed the tech-rename-product-card-product-grid-item branch from e5d0954 to ff18c7e Compare September 18, 2024 11:57
This was referenced Sep 18, 2024
Merged
Merged
Merged
Merged
@Youakeem Youakeem force-pushed the tech-rename-product-card-product-grid-item branch 2 times, most recently from 8c4b054 to d86ec14 Compare September 18, 2024 15:19
@Youakeem Graphite App
Copy link
Contributor Author

Youakeem commented Sep 19, 2024 •
edited
Loading

Merge activity

  • Sep 19, 3:16 AM EDT: @Youakeem started a stack merge that includes this pull request via Graphite.
  • Sep 19, 3:17 AM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 19, 3:24 AM EDT: @Youakeem merged this pull request with Graphite.

@Youakeem Youakeem force-pushed the tech-rename-product-card-product-grid-item branch from d86ec14 to 4b1e52c Compare September 19, 2024 07:16
@Youakeem Youakeem merged commit 5f1f98a into main Sep 19, 2024
5 checks passed
@Youakeem Youakeem deleted the tech-rename-product-card-product-grid-item branch September 19, 2024 07:24
This was referenced Sep 19, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilhermespopolin guilhermespopolin guilhermespopolin approved these changes

@gustaveen gustaveen gustaveen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Youakeem @gustaveen @guilhermespopolin