Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tech: Move Switch component to ui package #4730

Merged
merged 1 commit into from
Sep 19, 2024
Merged

tech: Move Switch component to ui package #4730

merged 1 commit into from
Sep 19, 2024
+126 −61

Conversation

Youakeem
Copy link
Contributor

@Youakeem Youakeem commented Sep 18, 2024 •
edited
Loading

Describe your changes

Subj

Justify why they are needed

Generic UI component and building block for ToggleCard

Checklist before requesting a review

  • I have performed a self-review of my code

@vercel Vercel
Copy link

vercel bot commented Sep 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hedvig-dot-com ✅ Ready (Inspect) Visit Preview Sep 19, 2024 0:58am

This was referenced Sep 18, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@Youakeem Graphite App
Copy link
Contributor Author

Youakeem commented Sep 18, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Youakeem and the rest of your teammates on Graphite Graphite

This was referenced Sep 18, 2024
Merged
Merged
Merged
Merged
Merged
@Youakeem Youakeem force-pushed the 09-19-move-useHighlightAnimation-ui branch from 359001b to 2f32e77 Compare September 18, 2024 10:58
@Youakeem Youakeem changed the title Move Switch component to ui package Move Switch component to ui package Sep 18, 2024
@Youakeem Youakeem force-pushed the 09-19-move-useHighlightAnimation-ui branch from 2f32e77 to a15d20c Compare September 18, 2024 11:52
@Youakeem Youakeem force-pushed the 09-19-move-useHighlightAnimation-ui branch from a15d20c to c5dd690 Compare September 18, 2024 11:58
This was referenced Sep 18, 2024
Merged
Merged
@Youakeem Youakeem marked this pull request as ready for review September 18, 2024 14:46
@Youakeem Youakeem requested a review from a team as a code owner September 18, 2024 14:46
@Youakeem Youakeem force-pushed the 09-19-move-useHighlightAnimation-ui branch from c5dd690 to 00be299 Compare September 18, 2024 15:17
@Youakeem Youakeem force-pushed the 09-19-move-useHighlightAnimation-ui branch from 00be299 to 33e6b24 Compare September 18, 2024 15:20
guilhermespopolin
guilhermespopolin approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@guilhermespopolin guilhermespopolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Youakeem Youakeem force-pushed the 09-19-move-useHighlightAnimation-ui branch from 33e6b24 to 5327f0e Compare September 19, 2024 10:08
This was referenced Sep 19, 2024
Merged
Merged
@Youakeem Youakeem force-pushed the 09-19-move-useHighlightAnimation-ui branch from 5327f0e to 6351c79 Compare September 19, 2024 11:37
@Youakeem Youakeem force-pushed the 09-19-move-useHighlightAnimation-ui branch 2 times, most recently from 85aeaca to ba7e741 Compare September 19, 2024 12:28
@Youakeem Youakeem changed the base branch from 09-19-move-useHighlightAnimation-ui to graphite-base/4730 September 19, 2024 12:41
@Youakeem Youakeem changed the base branch from graphite-base/4730 to main September 19, 2024 12:42
gustaveen
gustaveen approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@gustaveen gustaveen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Youakeem Youakeem merged commit e0d99b4 into main Sep 19, 2024
5 checks passed
@Youakeem Graphite App
Copy link
Contributor Author

Merge activity

@Youakeem Youakeem deleted the 09-18-move-Switch-ui branch September 19, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustaveen gustaveen gustaveen approved these changes

@guilhermespopolin guilhermespopolin guilhermespopolin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Youakeem @gustaveen @guilhermespopolin