Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose standardising compile-time logging using scala-logging instead of
println
.The main purpose of using a logging framework is to switch compile-time logging levels easily. At present (2024-12-10), XiangShan prints very detailed STDOUT when compiling, including issueQueue connection details, wakeUp network details and even every CSR. These information is not useful when working on other modules. In contrast, useful debug info is buried in huge amount of STDOUT print.
Therefore I propose using scala-logging as a logging framework, and the following definition mapping for log-level.
The example output of default logging level INFO is as follows. Note that this is incomplete and more work is going on to transform
println
tologger.xxx
.Currently, switching the log-level is done by
make VERBOSE=1
which sets the log-level to ALL. Maybe more options should be added to control every level of logging.