Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/osc #311

Merged
merged 19 commits into from
Nov 22, 2023
Merged

Feat/osc #311

merged 19 commits into from
Nov 22, 2023

Conversation

cremebrule
Copy link
Contributor

No description provided.

@cremebrule cremebrule requested a review from ChengshuLi November 1, 2023 20:13
ChengshuLi
ChengshuLi approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@ChengshuLi ChengshuLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some minor comments. I kind of rubber stamp on the OSC class itself because I am not as familiar, but things look good at first glance.

omnigibson/__init__.py Show resolved Hide resolved
omnigibson/prims/entity_prim.py Outdated Show resolved Hide resolved
omnigibson/prims/joint_prim.py Show resolved Hide resolved
omnigibson/robots/manipulation_robot.py Show resolved Hide resolved
omnigibson/robots/manipulation_robot.py Outdated Show resolved Hide resolved
omnigibson/controllers/osc_controller.py Outdated Show resolved Hide resolved
omnigibson/controllers/osc_controller.py Outdated Show resolved Hide resolved
omnigibson/controllers/osc_controller.py Show resolved Hide resolved
omnigibson/controllers/osc_controller.py Outdated Show resolved Hide resolved
omnigibson/controllers/osc_controller.py Outdated Show resolved Hide resolved
@cremebrule cremebrule merged commit 6c210a9 into og-develop Nov 22, 2023
2 of 3 checks passed
@cremebrule cremebrule deleted the feat/osc branch November 22, 2023 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChengshuLi ChengshuLi ChengshuLi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cremebrule @ChengshuLi