Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive action primitives examples and tests #842

Merged
merged 87 commits into from
Oct 1, 2024
Merged

Revive action primitives examples and tests #842

merged 87 commits into from
Oct 1, 2024

Conversation

yyf20001230
Copy link
Contributor

Prevent loading a robot with the wrong configuration upon initializing the environment

@yyf20001230 yyf20001230 requested a review from cgokmen August 21, 2024 22:12
@cgokmen cgokmen changed the title Scene file robot loading bugfix Don't load scene robot's state into env-created new robot Aug 21, 2024
@cgokmen
Copy link
Contributor

cgokmen commented Aug 21, 2024

This is a pre-step for #844

@yyf20001230
Copy link
Contributor Author

Changed fetch robot arm from ik controller to joint controller

  • Additional fixes on torch tensors

Action items

  • Fix use_delta_motion arm behavior
  • performing grasping does not pick up the object (video attached)
  • performing grasping when navigation is still necessary, navigate_to_pose not triggered / invalid RRT solution (video attached)

Screencast from 08-26-2024 07:25:12 PM.webm
Screencast from 08-26-2024 07:27:27 PM.webm

@yyf20001230 yyf20001230 changed the title Don't load scene robot's state into env-created new robot Revive action primitives example and test Sep 6, 2024
@yyf20001230
Copy link
Contributor Author

yyf20001230 commented Sep 6, 2024

Revived the action primitives test (symbolic primitives test wip) and examples for both Fetch and Tiago robot

Fixed issues:
Fixed issue 1: the sticky grasp does not pick up the object issue - caused by multi-scene import
Fixed issue 2: the settle_robot action raises the robot arm instead of performing an no-op
Fixed issue 3: torch tensors dtype for Fetch and Tiago
Fixed issue 4: action primitives navigation across all example scenes
Fixed issue 5: added a more verbose output of the action primitive errors
Fixed issue 6: Don't load scene robot's state into env-created new robot, prevent loading a robot with the wrong configuration upon initializing the environment

Pending issues:
Collision detection with the grasped object, pending for curobo implementation

@cgokmen cgokmen added this to the v1.1.0 milestone Oct 1, 2024
@cgokmen cgokmen merged commit 9b81f8f into og-develop Oct 1, 2024
1 of 11 checks passed
@cgokmen cgokmen deleted the curobo branch October 1, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants