Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OOC prefix proc #2536

Merged
merged 16 commits into from
Aug 17, 2023
Merged

OOC prefix proc #2536

merged 16 commits into from
Aug 17, 2023

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Jan 31, 2023

About the pull request

Adds a proc to check OOC prefixes, and adds prefixes for Staff and Mentor. Allows for clear indication of who's talking in OOC, and useful for planned restructure.

Explain why it's good for the game

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Added prefixes in OOC for Staff and Mentors. Created a proc to check for these prefixes and Donator.
fix: Fixed isCouncil check.
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Jan 31, 2023
Copy link
Contributor

@nauticall nauticall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gave u better icons to you via DM, let me know of any suggestions to make.

putting on hold until some version of better stuff is implemented ✋

@nauticall nauticall added the Sprites Remove the soul from the game. label Feb 3, 2023
@nauticall nauticall marked this pull request as draft February 3, 2023 15:48
@github-actions github-actions bot added the Merge Conflict PR can't be merged because it touched too much code label Feb 6, 2023
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Feb 14, 2023
@realforest2001
Copy link
Member Author

Closing for now as I'm dealing with medical issues that are taking my attention. Will reopen when I have the abilty to do it justice.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Aug 10, 2023
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@realforest2001 realforest2001 requested review from nauticall and Zonespace27 and removed request for monkeysfist101 August 10, 2023 12:05
@harryob harryob added this pull request to the merge queue Aug 17, 2023
Merged via the queue into cmss13-devs:master with commit b4121c8 Aug 17, 2023
25 checks passed
cm13-github added a commit that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants