Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xenos no longer can pull dead xenos #3666

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

morrowwolf
Copy link
Member

@morrowwolf morrowwolf commented Jun 18, 2023

About the pull request

This PR makes it so xenos can no longer pull dead xenos (or other non-human typepathed dead mobs).

The exception is dead larva.

When #3644 is merged I'll likely add xeno corpses so as to minimize clutter/wall blocking.

Explain why it's good for the game

Recovering corpses for marines is an important part of multiple gameplay loops now. We shouldn't really be seeing stacks of xeno corpses in hives.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 Morrow
balance: Xenos no longer can pull dead xenos
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Jun 18, 2023
@ihatethisengine

This comment was marked as off-topic.

@morrowwolf morrowwolf marked this pull request as draft June 18, 2023 20:17
@morrowwolf morrowwolf marked this pull request as ready for review June 18, 2023 20:57
@scoutskywalker

This comment was marked as off-topic.

@cm13live
Copy link

This pull request has been mentioned on CM-SS13. Please provide feedback here:

https://forum.cm-ss13.com/t/whats-with-all-the-xeno-overhauls-lately/2753/22

@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jun 27, 2023
@Chrismmar Chrismmar mentioned this pull request Jun 27, 2023
3 tasks
@Drulikar Drulikar added this pull request to the merge queue Jun 28, 2023
Merged via the queue into cmss13-devs:master with commit 613e967 Jun 28, 2023
27 checks passed
github-actions bot added a commit that referenced this pull request Jun 28, 2023
cm13-github added a commit that referenced this pull request Jun 28, 2023
@morrowwolf morrowwolf deleted the xeno-dead-drag branch June 28, 2023 08:07
@Drulikar Drulikar mentioned this pull request Dec 4, 2023
github-merge-queue bot pushed a commit that referenced this pull request Dec 16, 2023
# About the pull request

This PR is a followup to #3644 and #3666 to implement the weeded states
for xenos. I only created 3 states but the images are unique per caste
other than drones that have the same silhouette as lurkers, spitters,
and sentinels.

As before, only bodies that are no longer draggable by xenos can merge
with weeds when dead. This means larva and bursted do not merge with
weeds.

# Explain why it's good for the game

Much like the case for humans, this is for more immersion and to
declutter the battlefield. Technically it makes IO's jobs slightly
harder since they need to clear weeds to more easily find xeno corpses,
but they should be clearing weeds anyways.

# Testing Photographs and Procedure

![0](https://github.com/cmss13-devs/cmss13/assets/76988376/a4a2ba67-e2ee-4ac6-95f1-15a5e6bc0770)

![1](https://github.com/cmss13-devs/cmss13/assets/76988376/d8cf56b4-3f46-4c7b-8f00-3aafddfdd3c5)

![2](https://github.com/cmss13-devs/cmss13/assets/76988376/02630b1c-1f97-46ea-8267-1ded2066b241)

![3](https://github.com/cmss13-devs/cmss13/assets/76988376/c5b4c6fd-4fe4-4bc1-a1a8-badf7ee0eb4d)

![4](https://github.com/cmss13-devs/cmss13/assets/76988376/11acffca-eb7b-4de2-941a-2a771a00b0f7)

Tweaked Queen to remove most black pixels immediately:

![image](https://github.com/cmss13-devs/cmss13/assets/76988376/7e3f8997-869a-402a-9e8f-841d152c2f70)

# Changelog
:cl: Drathek
add: Implemented xeno corpse weed merging
imageadd: Added 48 sprites, 3 stages per caste silhouette, for xeno
weeded corpses
fix: Fixes ghosts not displaying their name on hover if weeded and weird
behavior when orbited via ctrl+click
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants