-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto observer fixes, preferences, and QoL #4463
Merged
harryob
merged 12 commits into
cmss13-devs:master
from
morrowwolf:observer-fixes-and-breaking-screens
Sep 26, 2023
Merged
Auto observer fixes, preferences, and QoL #4463
harryob
merged 12 commits into
cmss13-devs:master
from
morrowwolf:observer-fixes-and-breaking-screens
Sep 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Fix
Fix one bug, make ten more
Code Improvement
Make the code longer
labels
Sep 21, 2023
morrowwolf
changed the title
Observer fixes and (probably) breaking client screens
Auto observer fixes, preferences, and QoL
Sep 21, 2023
Gotta probably store the client somewhere in case they ghost, same with qdel as it wasn't clearing the registered signal |
3 tasks
3 tasks
This was referenced Sep 24, 2023
This was referenced Sep 24, 2023
This was referenced Sep 25, 2023
harryob
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR creates wrappers for screen additions and removals to allow for a creation of a signal observers can then register to so the observed screen changes are all changed on any observer's screen as well.
Let me be very clear: this needs a lot of testing and I did this kind of ad hoc just to see if it would work. Brief testing seems to show it working but I expect there are oversights and problems. More than likely I am recreating the wheel in some way and doing it the dumb way.
Explain why it's good for the game
Making the HUD observer more accurate is cool.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑 Morrow
add: Added a save-able preference for auto-observe
fix: Fixed numerous problems with HUD observer mode
code: Created a wrapper for client screen changes
code: Made check contents less horrendous
/:cl: