Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto observer fixes, preferences, and QoL #4463

Merged

Conversation

morrowwolf
Copy link
Member

@morrowwolf morrowwolf commented Sep 21, 2023

About the pull request

This PR creates wrappers for screen additions and removals to allow for a creation of a signal observers can then register to so the observed screen changes are all changed on any observer's screen as well.

Let me be very clear: this needs a lot of testing and I did this kind of ad hoc just to see if it would work. Brief testing seems to show it working but I expect there are oversights and problems. More than likely I am recreating the wheel in some way and doing it the dumb way.

Explain why it's good for the game

Making the HUD observer more accurate is cool.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 Morrow
add: Added a save-able preference for auto-observe
fix: Fixed numerous problems with HUD observer mode
code: Created a wrapper for client screen changes
code: Made check contents less horrendous
/:cl:

@github-actions github-actions bot added Fix Fix one bug, make ten more Code Improvement Make the code longer labels Sep 21, 2023
@morrowwolf morrowwolf changed the title Observer fixes and (probably) breaking client screens Auto observer fixes, preferences, and QoL Sep 21, 2023
@morrowwolf
Copy link
Member Author

Gotta probably store the client somewhere in case they ghost, same with qdel as it wasn't clearing the registered signal

@Biolock1 Biolock1 mentioned this pull request Sep 22, 2023
3 tasks
@harryob harryob added this pull request to the merge queue Sep 26, 2023
Merged via the queue into cmss13-devs:master with commit 7be68a9 Sep 26, 2023
25 checks passed
cm13-github added a commit that referenced this pull request Sep 26, 2023
@morrowwolf morrowwolf deleted the observer-fixes-and-breaking-screens branch September 26, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants