Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Egg Changes #5054

Merged
merged 3 commits into from
Dec 9, 2023
Merged

Egg Changes #5054

merged 3 commits into from
Dec 9, 2023

Conversation

Zonespace27
Copy link
Contributor

@Zonespace27 Zonespace27 commented Nov 28, 2023

About the pull request

Now that #4716 's been merged, here's the changes I've wanted to make for eggs for a bit now.

  • Eggs can no longer be planted in vehicles
  • Eggs can no longer be planted on tiles that would obstruct the egg.

Explain why it's good for the game

  • In the vast majority of cases, you cannot tell that a vehicle you're entering is infested with you-instantly-lose eggs. While normally getting hit with an egg is reasonably predictable (there are weeds == possibility of eggs), having no indication of it until you go inside and get hugged isn't fun or balanced.
  • Eggs being able to layer under things like grass is technically a "feature", but not one I would like to keep. Traps serve the exact same purpose, but are much harder to mass produce (as intended). Eggs should be cheaper but more detectable, which doesn't align them being able to be near-fully hidden.

Testing Photographs and Procedure

Screenshots & Videos

image

Changelog

🆑
balance: You cannot plant eggs inside vehicles.
balance: Eggs can no longer be planted on tiles with objects that would obscure them.
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Nov 28, 2023
@Zonespace27 Zonespace27 marked this pull request as draft November 28, 2023 03:01
@Zonespace27 Zonespace27 marked this pull request as ready for review November 28, 2023 03:53
@Releasethesea
Copy link
Contributor

since this is TM'd i assume i can leave feedback on it, so far my experience has been very inconsistent i can place eggs in some corners and some others i cant ive also not been able to place eggs when there is a railing next to them, aswell as from what ive seen papers and other items on the floors, like roller chairs

Copy link
Contributor

@Birdtalon Birdtalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TM hasn't highlighted any obvious issues with this.

@Zonespace27 Zonespace27 added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Dec 8, 2023
@Zonespace27
Copy link
Contributor Author

Thought over it a bit, can't think of a better way to do this atm

@Zonespace27 Zonespace27 marked this pull request as ready for review December 8, 2023 00:45
Copy link
Contributor

@Birdtalon Birdtalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TM has been going quite a while with no obvious unintended effects.

@Birdtalon Birdtalon added this pull request to the merge queue Dec 9, 2023
Merged via the queue into cmss13-devs:master with commit 961d967 Dec 9, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants