Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Sunsets to Roundstart, adds Sunrises to Marine Victories, and Survs can hear Evo Announcement Screeches now #6400

Closed

Conversation

GrrrKitten
Copy link
Contributor

@GrrrKitten GrrrKitten commented Jun 8, 2024

About the pull request

I'm not gonna lie, im burnt out asf from working on this PR, so im keeping this super brief.

Adds:
new special lighting system to handle z-level wide lighting modifications with consistent lighting, this can be used for stuff I made in this PR like sunsets, or it can be used for stuff like lightning strikes (hint hint for the future)

-2 new sunsets, one warm and one cold, each last ~280 seconds but you lose visibility ~240 or so seconds
-1 new sunrise, very warm, finishes up on a cinematic orange tone around the time the map vote thing pops up, theres a vid
-1 new call for survs to hear a special modified version of the evo screech, its pretty cool, its gonna make survs piss themselves cause it kept jumpscaring me during my testing lol, its in the vids

sunset is called at round start based on gamemode (only attatched to distress rn, cold maps, space maps, and chances claim get cold sunset, all others get warm sunset)

sunrise is called on marine major

things like getting spawned, z-transfers, leaving your body, entering a new body, changing alpha (in the case of ghosts or xenos), entering/leaving a cave is all handled within the lighting system so noone gets an unfair advantage/major disadvantage.


balance implications:

humans:
pros:
-survs have ~3 minutes of good visibility from round start, meaning easier time seeing items and less chance of getting snuck up on
-if there is like still a lurker or something delaying but the round end thing has been called, the lack of darkness means itll get killed easier

xenos:
pros:
-survs will probably be a lil overconfident and likely to travel alone
-survs will probably be a bit more scared of caves
-xenos technically have better visibility in the daytime too for whatever that counts lol

the drone horde is coming the drone horde is coming the drone horde is coming


things that I couldnt test:

  • I couldnt test if the delaylien marine victory actually called sunset so thats gonna require a live server

Explain why it's good for the game

It just looks amazing, just flatout. even the same sunset on two different map entirely changes the feel on both cause of the interaction of colors.

walking around as surv you feel yourself slowly becoming disoriented, something about having full light and having it slowly be taken from you somehow is worse than just starting in the pitch dark. the new screeches make you feel HUNTED as surv even when its bright out

Testing Photographs and Procedure

Screenshots & Videos

I really dont feel like getting a vid on every map but like, the exact same sunset on two different maps looks entirely different. you just gotta experience it to understand

Sorry but the videos dont embed

cold sunset on CC
https://streamable.com/9w1h7h

cold sunrise on CC
https://streamable.com/bf39yc

warm sunset on LV
https://streamable.com/1ihsam

warm sunrise on LV
https://streamable.com/hahm94

Like the stuff I make?
ko-fi

Changelog

🆑
add: Adds Sunsets to roundstart
add: Adds Sunrises to marine victories
add: Adds survs being able to hear evo announcement screeches
/:cl:

@github-actions github-actions bot added Sound Blast 5 minutes of bass boosted music to our players Feature Feature coder badge labels Jun 8, 2024
@GrrrKitten GrrrKitten marked this pull request as ready for review June 10, 2024 02:00
@GrrrKitten GrrrKitten requested a review from fira as a code owner June 10, 2024 02:00
if(issynth(groundmob))
to_chat(groundmob, SPAN_HIGHDANGER("You hear the distant call of an unknown bioform, it sounds like they're informing others to change form. You begin to analyze and decrypt the strange vocalization."))
initial_screech = FALSE
return
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im pretty sure this will send the to chat to whatever mob is first in the list and exit the proc due to this return. You sure this is good?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is still a return, not a continue, by the way

@s5nt
Copy link
Contributor

s5nt commented Jun 10, 2024

Bone chilling, spine tingling, genre redefining, status-quo subverting, shining, glistening, gemerald.

On a more serious note, this helps to solve the issue of like half the hive evoing drone straight away and rushing survs, which if we're being realistic here survs just get fucked by and there's not really any fighting back.

@GrrrKitten
Copy link
Contributor Author

Bone chilling, spine tingling, genre redefining, status-quo subverting, shining, glistening, gemerald.

On a more serious note, this helps to solve the issue of like half the hive evoing drone straight away and rushing survs, which if we're being realistic here survs just get fucked by and there's not really any fighting back.

If Im being honest, I don't think sunsets will 'solve' drone hordes in the slightest, drone hordes are brutal, but I also don't think theyre that bad of a thing, theyre cool AF to see and very thematic imo. If its still super early into the sunset, itll definitely help you against a single drone and allow you to put more distance inbetween it and yourself, but being able to see your surroundings isnt gonna help you when 6 drones are closing in fast

code/_onclick/hud/fullscreen.dm Outdated Show resolved Hide resolved
code/_onclick/hud/fullscreen.dm Outdated Show resolved Hide resolved
code/_onclick/hud/fullscreen.dm Outdated Show resolved Hide resolved
code/_onclick/hud/fullscreen.dm Outdated Show resolved Hide resolved
code/_onclick/hud/fullscreen.dm Outdated Show resolved Hide resolved
code/_onclick/hud/fullscreen.dm Outdated Show resolved Hide resolved
code/_onclick/hud/fullscreen.dm Outdated Show resolved Hide resolved
code/_onclick/hud/fullscreen.dm Outdated Show resolved Hide resolved
code/_onclick/hud/fullscreen.dm Outdated Show resolved Hide resolved
code/_onclick/hud/fullscreen.dm Outdated Show resolved Hide resolved
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

veros reviews are all accurate, too

code/modules/mob/living/carbon/xenomorph/hive_status.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft June 15, 2024 14:02
@GrrrKitten
Copy link
Contributor Author

Tested and functional

cm13-github added a commit that referenced this pull request Jul 17, 2024
cm13-github added a commit that referenced this pull request Jul 17, 2024
cm13-github added a commit that referenced this pull request Jul 17, 2024
@cm13-issue-bot cm13-issue-bot mentioned this pull request Jul 17, 2024
cm13-github added a commit that referenced this pull request Jul 17, 2024
cm13-github added a commit that referenced this pull request Jul 18, 2024
cm13-github added a commit that referenced this pull request Jul 19, 2024
cm13-github added a commit that referenced this pull request Jul 21, 2024
cm13-github added a commit that referenced this pull request Jul 21, 2024
cm13-github added a commit that referenced this pull request Jul 21, 2024
cm13-github added a commit that referenced this pull request Jul 21, 2024
cm13-github added a commit that referenced this pull request Jul 21, 2024
cm13-github added a commit that referenced this pull request Jul 21, 2024
cm13-github added a commit that referenced this pull request Jul 21, 2024
cm13-github added a commit that referenced this pull request Jul 21, 2024
cm13-github added a commit that referenced this pull request Jul 22, 2024
cm13-github added a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Sound Blast 5 minutes of bass boosted music to our players Stale beg a maintainer to review your PR Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants