Show on App Launch: Fix no option selected on rotation #5200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onStarted is too soon to set the checklist item after rotation (also TIL we're not always locked to portrait 😅)
This was referenced Oct 28, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @mikescamell and the rest of your teammates on |
10 tasks
mikescamell
merged commit a51844e
into
feature/mike/show-on-app-launch/implementation
6 of 7 checks passed
mikescamell
deleted the
feature/mike/show-on-app-launch/fix-no-option-selected-on-rotation
branch
mikescamell
added a commit
that referenced
this pull request
Oct 28, 2024
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208637287651029/f ### Description Fixes no options being selected then the phone is rotated. ### Steps to test this PR - [x] Open Show on App Launch screen in settings - [x] Rotate phone to landscape - [x] The same option that was selected should still be selected ### Demo https://github.com/user-attachments/assets/2fabd7ae-15c5-41e6-8b04-c78c13483d71
mikescamell
added a commit
that referenced
this pull request
Oct 30, 2024
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208637287651029/f ### Description Fixes no options being selected then the phone is rotated. ### Steps to test this PR - [x] Open Show on App Launch screen in settings - [x] Rotate phone to landscape - [x] The same option that was selected should still be selected ### Demo https://github.com/user-attachments/assets/2fabd7ae-15c5-41e6-8b04-c78c13483d71
mikescamell
added a commit
that referenced
this pull request
Nov 4, 2024
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208637287651029/f ### Description Fixes no options being selected then the phone is rotated. ### Steps to test this PR - [x] Open Show on App Launch screen in settings - [x] Rotate phone to landscape - [x] The same option that was selected should still be selected ### Demo https://github.com/user-attachments/assets/2fabd7ae-15c5-41e6-8b04-c78c13483d71
mikescamell
added a commit
that referenced
this pull request
Nov 6, 2024
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208637287651029/f ### Description Fixes no options being selected then the phone is rotated. ### Steps to test this PR - [x] Open Show on App Launch screen in settings - [x] Rotate phone to landscape - [x] The same option that was selected should still be selected ### Demo https://github.com/user-attachments/assets/2fabd7ae-15c5-41e6-8b04-c78c13483d71
mikescamell
added a commit
that referenced
this pull request
Nov 6, 2024
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208637287651029/f ### Description Fixes no options being selected then the phone is rotated. ### Steps to test this PR - [x] Open Show on App Launch screen in settings - [x] Rotate phone to landscape - [x] The same option that was selected should still be selected ### Demo https://github.com/user-attachments/assets/2fabd7ae-15c5-41e6-8b04-c78c13483d71
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208637287651029/f
Description
Fixes no options being selected then the phone is rotated.
Steps to test this PR
Demo
Screen_recording_20241028_101212.mp4