Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs+CI] Add range sensor to controller index and lint job #767

Merged
merged 2 commits into from
Sep 7, 2023
Merged

[Docs+CI] Add range sensor to controller index and lint job #767

merged 2 commits into from
Sep 7, 2023

Conversation

christophfroehlich
Copy link
Contributor

A small appendix to #725

bmagyar
bmagyar approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!! I tried doing this via "review in codespace" last night but it didn't allow me to push...

@bmagyar bmagyar merged commit 4d0b999 into ros-controls:master Sep 7, 2023
14 checks passed
@bmagyar bmagyar added the backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. label Sep 7, 2023
mergify bot pushed a commit that referenced this pull request Sep 7, 2023
@christophfroehlich @mergify
[Docs+CI] Add range sensor to controller index and lint job (#767)
6ac2e04 
(cherry picked from commit 4d0b999)
@mergify mergify bot mentioned this pull request Sep 7, 2023
Merged
bmagyar pushed a commit that referenced this pull request Sep 7, 2023
@mergify @christophfroehlich
[Docs+CI] Add range sensor to controller index and lint job (#767) (#768
71d4888 
)

(cherry picked from commit 4d0b999)

Co-authored-by: Christoph Fröhlich <[email protected]>
@christophfroehlich christophfroehlich deleted the docs/fix_rangesensor_links branch September 14, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmagyar bmagyar bmagyar approved these changes

@bijoua29 bijoua29 Awaiting requested review from bijoua29

@destogl destogl Awaiting requested review from destogl

@harderthan harderthan Awaiting requested review from harderthan

@homalozoa homalozoa Awaiting requested review from homalozoa

@mhubii mhubii Awaiting requested review from mhubii

@rosterloh rosterloh Awaiting requested review from rosterloh

Assignees
No one assigned
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophfroehlich @bmagyar