[Draft][tflchef/circlechef] Use a dedicated type for custom operators #11750
Conversation
Seunghui98
added
DRAFT
| if (operation.type() == "Custom") | ||
| { | ||
| customcode_set.insert(operation.custom_code()); | ||
| continue; | ||
| } |
There was a problem hiding this comment.
These codes can substitute below codes.
auto op_chef = op_chef_registry().lookup(operation.type()).create(&operation);
if (op_chef->code() == circle::BuiltinOperator_CUSTOM)
customcode_set.insert(operation.type());Which means above codes should be removed.
There was a problem hiding this comment.
Thank you for the comment ! :)
| @@ -182,6 +194,12 @@ std::set<std::string> gather_customcode_set(const ::circlechef::ModelRecipe &mod | |||
| const auto &graph = model_recipe.graph(g); | |||
| for (const auto &operation : graph.operation()) | |||
| { | |||
| if (operation.type() == "Custom") | |||
Seunghui98
force-pushed
the
add_custom_code
branch
from
80847a1 to
f9cf248
Compare
| @@ -18,13 +18,14 @@ operand { | |||
| } | |||
| } | |||
| operation { | |||
| type: "All" | |||
| type: "Custom" | |||
There was a problem hiding this comment.
to land separate PRs for compiler and res files,
we need to introduce some intermediate changes
for example,
1/ in res, introduce extype: "Custom" and custom_code: "All"
2/ in tflchef, if extype exist, use that, if not use type
3/ in res, change type and remove extype
4/ in tflchef remove related with extype
There was a problem hiding this comment.
Thank you for your comment!! I will upload the code PR as you guided me. :)
Seunghui98
force-pushed
the
add_custom_code
branch
4 times, most recently
from
5f63b71 to
6950305
Compare
| @@ -29,7 +29,11 @@ AddV2Chef::custom_value(flatbuffers::FlatBufferBuilder &fbb) const | |||
| { | |||
| auto &operation = (*_operation); | |||
|
|
|||
| assert(operation.type() == "AddV2"); | |||
| if (operation.has_extype() && operation.extype() == "Custom") | |||
There was a problem hiding this comment.
why not check type() == Custom` too ?
| { | ||
| assert(operation.has_custom_code()); | ||
| assert(operation.custom_code() == "AddV2"); | ||
| } |
There was a problem hiding this comment.
as these blocks are repeated several times, would be better to add a method
Seunghui98
force-pushed
the
add_custom_code
branch
2 times, most recently
from
50d3808 to
874b1fd
Compare
On going draft to use a dedicated type for custom operators in the recipe. ONE-DCO-1.0-Signed-off-by: SeungHui Lee <[email protected]>
Seunghui98
force-pushed
the
add_custom_code
branch
from
874b1fd to
714621e
Compare
On going draft to use a dedicated type for custom operators in the recipe.
ONE-DCO-1.0-Signed-off-by: SeungHui Lee [email protected]
Related Issue : #11741