Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InfluxDB Metrics Backend #3601

Merged
merged 11 commits into from
Jul 1, 2023
Merged

Conversation

fira
Copy link
Member

@fira fira commented Jun 11, 2023

About the pull request

Wider scope version of #3480

This ships the following game metrics to InfluxDB:

  • Job occupations, tagged by "team" (humans/factions, xenos/hives...)
  • Online Players/Staff/Mentor
  • AHelp ticket statistics
  • Round-based statistics that are already DB-logged, such as chestbursts, FF hits, shots fired
  • Amount of pooled larvas
  • MC/SS timing info that was previously sent to SQL

It uses two separate subsystems, one for collecting metrics, the other for shipping them - and provides procs for easily sending more data to wire up other code.

Explain why it's good for the game

Gives fine grained control over game data that we don't have. Currently SOME of these are logged to SQL, and we'd need to create our own vis UI. Backing them by a TSDB allows to view evolutions over time, and means we can plug in standard dashboarding tooling like Grafana.

Testing Photographs and Procedure

image

(okay it's technically from a TM of the older PR)

Changelog

🆑
add: Added InfluxDB backed metrics logging for some of the most used game statistics. This will allow to graph them over time and give better insight as to what happens in rounds.
/:cl:

fira added 2 commits June 11, 2023 16:42
remove round_time, not workable

fix config

add missing stats exemption

srsly
@github-actions github-actions bot added the Feature Feature coder badge label Jun 11, 2023
@fira
Copy link
Member Author

fira commented Jun 12, 2023

Sidelined pending implementation of

tgstation/rust-g#130

Otherwise the timestamps are rounded to 1-2 minutes resolution which defeats half the point of this

Edit: Done as a temporary measure, now tick is timed to microsecond resolution (wow, very useful)

@fira fira marked this pull request as draft June 12, 2023 14:09
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jun 29, 2023
Copy link
Contributor

@BeagleGaming1 BeagleGaming1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been on TM for a month and nothings broken yet

@BeagleGaming1 BeagleGaming1 added this pull request to the merge queue Jul 1, 2023
Merged via the queue into cmss13-devs:master with commit b64af8e Jul 1, 2023
cm13-github added a commit that referenced this pull request Jul 1, 2023
github-actions bot added a commit that referenced this pull request Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants