-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes playing cards #5337
Fixes playing cards #5337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look fine and so far I don't see any problems just fiddling with cards though I don't know exactly the repro steps for the issue in the first place.
@@ -423,6 +438,12 @@ | |||
name = "a playing card" | |||
desc = "A playing card." | |||
|
|||
if(length(cards) >= 200) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if(length(cards) >= 200) | |
if(cards_length >= 200) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining issues with mousedrop I will try to tackle myself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is otherwise fine.
# About the pull request This PR resolves the unresolved issues in #5337 and should fix #4604 See testing for more details. One note is that we aren't actually doing anything different for mob/proc/u_equip for nomoveupdate. I attempted a few things including a snippet from tg's code (https://github.com/tgstation/tgstation/blob/master/code/modules/mob/inventory.dm#L377-L381) but at least for thrown items it would just make them poof; so for now I just corrected a misused call of it. # Explain why it's good for the game No more funny business nor weird inventory overlays (atleast for cards and stacks - let me know if there is anything else that has this behavior) # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Busted: https://github.com/cmss13-devs/cmss13/assets/76988376/a596d661-49f0-4f3e-b77e-51046676408c Fixed: https://github.com/cmss13-devs/cmss13/assets/76988376/98bc6680-d0b5-4ce8-b7a0-22629274d8ad </details> # Changelog :cl: Drathek fix: Fixed more item exploits fix: Fixed lingering overlays in inventories for metal stacks and cards /:cl:
About the pull request
3 layers of fixes for a pretty bad bug with playing cards you might have seen recently.
Changelog
🆑
fix: Fixed an exploit involving playing cards.
/:cl: