Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduces effects of impact ammo with range, proof of concept numbers can be adjusted #5552

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

cuberound
Copy link
Contributor

@cuberound cuberound commented Jan 25, 2024

About the pull request

attempt to adress the issue with offscreen stun rather then removing scope . NUMBERS ARE UP FOR DEBATE, they are just placeholders

Explain why it's good for the game

offscreen stun sucks shure, but that is not a reason to limit gameplay options, high impact should have lower effect with higer range just like it does with revolvers (a bit diferent aproach in this PR rather then having suden drop in effect it is gradual) also it has almoust no effect on close range spec reducing the effects by about 1/10 for stuff on screen

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: m4ra ammo looses about 1/5 of initial effect duration per 10 tiles traveled
/:cl:

@cuberound cuberound marked this pull request as ready for review January 25, 2024 16:44
@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Jan 25, 2024
@Nanu308 Nanu308 self-requested a review January 25, 2024 17:22
@Nanu308 Nanu308 added Testmerge Candidate we'll test this while you're asleep and the server has 10 players Needs Testing Need to test it on the guinea pigs (production server) labels Jan 30, 2024
@Superwelder Superwelder mentioned this pull request Feb 6, 2024
3 tasks
Copy link
Contributor

github-actions bot commented Feb 7, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Feb 7, 2024
@Drulikar Drulikar added Stale Exempt PR can't go stale and removed Stale beg a maintainer to review your PR labels Feb 9, 2024
@LynxSolstice LynxSolstice mentioned this pull request Feb 9, 2024
3 tasks
cm13-github added a commit that referenced this pull request Feb 10, 2024
cm13-github added a commit that referenced this pull request Feb 10, 2024
cm13-github added a commit that referenced this pull request Feb 11, 2024
@Syndro101 Syndro101 mentioned this pull request Feb 11, 2024
3 tasks
cm13-github added a commit that referenced this pull request Feb 12, 2024
cm13-github added a commit that referenced this pull request Feb 12, 2024
cm13-github added a commit that referenced this pull request Feb 12, 2024
@ekcja1 ekcja1 mentioned this pull request Feb 12, 2024
3 tasks
cm13-github added a commit that referenced this pull request Feb 13, 2024
cm13-github added a commit that referenced this pull request Feb 13, 2024
@Crimsonerva Crimsonerva mentioned this pull request Feb 13, 2024
3 tasks
@FighterOfKeyboard FighterOfKeyboard mentioned this pull request Feb 13, 2024
3 tasks
cm13-github added a commit that referenced this pull request Feb 14, 2024
cm13-github added a commit that referenced this pull request Feb 14, 2024
cm13-github added a commit that referenced this pull request Feb 14, 2024
cm13-github added a commit that referenced this pull request Feb 14, 2024
cm13-github added a commit that referenced this pull request Feb 14, 2024
cm13-github added a commit that referenced this pull request Feb 15, 2024
cm13-github added a commit that referenced this pull request Feb 15, 2024
@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Feb 15, 2024
@Drulikar Drulikar added this pull request to the merge queue Feb 15, 2024
Merged via the queue into cmss13-devs:master with commit f85c31f Feb 15, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Needs Testing Need to test it on the guinea pigs (production server) Stale Exempt PR can't go stale Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants