Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better throw logic #6040

Merged
merged 2 commits into from
Apr 13, 2024
Merged

Better throw logic #6040

merged 2 commits into from
Apr 13, 2024

Conversation

Git-Nivrak
Copy link
Contributor

@Git-Nivrak Git-Nivrak commented Mar 29, 2024

About the pull request

Throw will now attempt to reach the target rather than the a predefined path that could change if thrown towards an object

Tested on local but this affect a lot of stuff so needs to be tested

Explain why it's good for the game

When you try to throw something and the target slightly moves one nanosecond after you throw it sucks

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Throws will now attempt to reach their target rather than the turf they were on when thrown
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Mar 29, 2024
@SabreML SabreML added the Needs Testing Need to test it on the guinea pigs (production server) label Mar 29, 2024
@SabreML
Copy link
Member

SabreML commented Mar 29, 2024

This may fix #5967, but that's a hard one to reproduce.

@Drulikar Drulikar added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 3, 2024
cm13-github added a commit that referenced this pull request Apr 4, 2024
cm13-github added a commit that referenced this pull request Apr 5, 2024
cm13-github added a commit that referenced this pull request Apr 5, 2024
cm13-github added a commit that referenced this pull request Apr 6, 2024
@Katskan Katskan mentioned this pull request Apr 6, 2024
3 tasks
cm13-github added a commit that referenced this pull request Apr 7, 2024
cm13-github added a commit that referenced this pull request Apr 7, 2024
cm13-github added a commit that referenced this pull request Apr 7, 2024
cm13-github added a commit that referenced this pull request Apr 7, 2024
cm13-github added a commit that referenced this pull request Apr 7, 2024
@Wintermote Wintermote mentioned this pull request Apr 8, 2024
3 tasks
cm13-github added a commit that referenced this pull request Apr 8, 2024
cm13-github added a commit that referenced this pull request Apr 8, 2024
cm13-github added a commit that referenced this pull request Apr 8, 2024
cm13-github added a commit that referenced this pull request Apr 8, 2024
cm13-github added a commit that referenced this pull request Apr 8, 2024
cm13-github added a commit that referenced this pull request Apr 8, 2024
cm13-github added a commit that referenced this pull request Apr 8, 2024
cm13-github added a commit that referenced this pull request Apr 9, 2024
@Hopekz
Copy link
Contributor

Hopekz commented Apr 9, 2024

I like throwing missing because dodging people's throws is a mechanic in itself imo vs being like a homing rocket like whenever the guy from hitman throws an item.

@Drulikar Drulikar added this pull request to the merge queue Apr 13, 2024
Merged via the queue into cmss13-devs:master with commit a032331 Apr 13, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Apr 13, 2024
@ItsVyzo ItsVyzo mentioned this pull request Apr 18, 2024
github-merge-queue bot pushed a commit that referenced this pull request Apr 21, 2024
# About the pull request
Unforseen consequences
Will have to take a look at redoing it at some point though it made me
doubt it is even necessary
<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->

# Explain why it's good for the game
# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
del: Reverted back to old throw logic
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Needs Testing Need to test it on the guinea pigs (production server) Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants