Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylons now count only groundside marines, xenos get major boost to evo speed for 3 minutes after hijack #5122

Merged
merged 31 commits into from
Jan 6, 2024

Conversation

ihatethisengine
Copy link
Contributor

@ihatethisengine ihatethisengine commented Dec 4, 2023

About the pull request

Pylons give larva only up to 50% of groundside (weighted) marines, instead of 40% of all humans.
Xenos get major boost to evo speed for 3 minutes after hijack, also hijacking removes ovi cd.

Explain why it's good for the game

Larva surge works this way (but for shipside), and pylons were kinda meant to work this way too. Current implementation encourages xenos to delay hijack as long as possible to get the maximum larva, get evo etc. which is not good. It shouldn't break balance too much, you should be able to defeat marines if you have 40% of their force.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 ihatethisengine
balance: Pylons give larva only up to 50% of groundside (weighted) marines, instead of 40% of all humans.
balance: Xenos get major boost to evo speed for 3 minutes after hijack. Hijacking resets ovi cooldown.
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Dec 4, 2023
@ihatethisengine ihatethisengine marked this pull request as ready for review December 5, 2023 04:57
@ihatethisengine ihatethisengine marked this pull request as draft December 5, 2023 05:00
@ihatethisengine

This comment was marked as outdated.

@ihatethisengine ihatethisengine marked this pull request as ready for review December 5, 2023 07:20
@Birdtalon Birdtalon added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Dec 5, 2023
@Birdtalon
Copy link
Contributor

Birdtalon commented Dec 5, 2023

I'd say this needs balance approval since xeno endgame relies largely on pylon larva at the moment to siege and then execute a successful hijack. Based on my gut feeling this PR could reduce the larva gain by anything from 20-50% some rounds which I would say is not insignificant.

Edit: Feel free to correct me as I haven't looked into the job weightings impact yet, just back of a napkin guestimate.

@ihatethisengine
Copy link
Contributor Author

We can up the number to 50%. Theoretically all groundside marines (except doctors) should have weight of 1, so it shouldn't be an issue. Realistically if you have 20 xenos vs 40 marines it's xeno major, especially since you get new xenos when old xenos die.

@GoldenDarkness55
Copy link
Contributor

less numbers = you're even more encouraged to wait for evo.
Just add some kinda check for queen ovi on DS that speeds evo up tenfold for a minute or smth

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Dec 7, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Dec 8, 2023
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Dec 16, 2023
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Dec 19, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Dec 19, 2023
@Drulikar Drulikar marked this pull request as draft January 3, 2024 23:06
@ihatethisengine ihatethisengine marked this pull request as ready for review January 4, 2024 00:03
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look fine.

@realforest2001 realforest2001 added this pull request to the merge queue Jan 6, 2024
Merged via the queue into cmss13-devs:master with commit 30bd13c Jan 6, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants