Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V] Sorokyne Strata: Expanded Small corridors, removed 3000 unused tiles, Xenos can now weed everything except LZ's and surrounding of LZ's, allow LAZ for CAS inside structures with light blue Areas on Tacmap (glass ceiling hallways) #6071

Merged
merged 38 commits into from
Sep 29, 2024

Conversation

Venuska1117
Copy link
Contributor

@Venuska1117 Venuska1117 commented Apr 3, 2024

About the pull request

This PR clean Sorokyne Strata file from excessive lines of code caused by APC's and small light fixture.
It changes some small rooms with have 1x1 hallways, now if possible, they are 2x2 (minimum).
Replaced 80% of indestructable walls with heavy reinforced walls, i dont see need for indestructable walls if they are not critical (for example, map edge)
Shortened river by half (south west near LZ) and placed invisible wall, i tough of preventing (in future) for burrowers to getting there and re-evolve to queen in spot where marines have no access because of invisible wall.
It "removes" walls with are 2tiles or more thick, i don't know why there are 2 tiles thick walls, but i believe they are not important.
Removes around 3000 unused tiles.

Edit: 08.08

  • Allow xenos to weed everywhere (except LZ's)
  • Allow marines to use LAZ for CAS inside most structures that have light blue colored areas (hallways made of glass ceiling)

Fixes: #6869

Explain why it's good for the game

Less lines of code allow for quicker groundsite loading, even if its second faster, and also allow for more map destruction with less chockes caused by 1x1 tunnels, they don't appear much but they are "annoying", allow marines to use LAZ for CAS inside most structures (not all of them) and xenos can now weed 90% of areas except LZ's

Testing Photographs and Procedure

Screenshots & Videos

img1

img2

img3

img4

img5

img6

img7

img8

img9

Changelog

🆑 Venuska1117
maptweak: Sorokyne Strata - made most indestructable walls destructable.
maptweak: Sorokyne Strata - changed rooms/hallways with have 1x1 hallways to be wider.
maptweak: Sorokyne Strata - replaced some small light fixtures with normal light fixtures.
maptweak: Sorokyne Strata - reduced 2 tiles or more thick walls to 1 tile thick walls.
balance: Made most areas weedable, except LZ's zones and surrounding LZ's sub-variants.
balance: Allow LAZ inside Outposts (mining and normal ones) as long as they aim at light blue areas (glass ceiling hallways).
code: Changed pixel offset for "tube" lights to be closer to "floor".
/:cl:

@github-actions github-actions bot added the Mapping did you remember to save in tgm format? label Apr 3, 2024
@Venuska1117 Venuska1117 changed the title [VEN] Sorokyne Strata: small fixes and changes . [V] Sorokyne Strata: small fixes and changes . Apr 3, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Apr 12, 2024
@Nanu308 Nanu308 removed the Stale beg a maintainer to review your PR label Apr 14, 2024
@Nanu308 Nanu308 marked this pull request as draft April 14, 2024 10:23
@Venuska1117
Copy link
Contributor Author

Venuska1117 commented Apr 16, 2024

@Nanu308 can you please check map again, i removed changed south part of south jungle to remove around 3000-4000 unused tiles (considering i already removed long river) and moved some queen "nest" spots to better points (like one between hot springs and carp lake) more south of hot springs, i did this changes (movin nests) because by gameplay perspective you are unable to weed water/coast.

(sorry if i did this many changes when you already pointed out issues)

@Venuska1117 Venuska1117 marked this pull request as ready for review April 18, 2024 17:59
@Venuska1117 Venuska1117 changed the title [V] Sorokyne Strata: small fixes and changes . [V] Sorokyne Strata: fixes and changes . Apr 24, 2024
Copy link
Contributor

github-actions bot commented May 2, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label May 2, 2024
@Nanu308 Nanu308 marked this pull request as draft May 5, 2024 17:11
@Nanu308 Nanu308 removed the Stale beg a maintainer to review your PR label May 5, 2024
cm13-github added a commit that referenced this pull request Sep 20, 2024
cm13-github added a commit that referenced this pull request Sep 20, 2024
cm13-github added a commit that referenced this pull request Sep 23, 2024
cm13-github added a commit that referenced this pull request Sep 23, 2024
cm13-github added a commit that referenced this pull request Sep 24, 2024
cm13-github added a commit that referenced this pull request Sep 26, 2024
cm13-github added a commit that referenced this pull request Sep 26, 2024
cm13-github added a commit that referenced this pull request Sep 28, 2024
cm13-github added a commit that referenced this pull request Sep 28, 2024
This was referenced Sep 28, 2024
cm13-github added a commit that referenced this pull request Sep 29, 2024
@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Sep 29, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be some oversights, but nothing immediately popping out.

Copy link
Contributor Author

@Venuska1117 Venuska1117 Sep 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you for review and merge!

@Nanu308 Nanu308 added this pull request to the merge queue Sep 29, 2024
Merged via the queue into cmss13-devs:master with commit 521b35a Sep 29, 2024
28 checks passed
cmss13-ci bot added a commit that referenced this pull request Sep 29, 2024
@cm13-issue-bot cm13-issue-bot mentioned this pull request Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Code Improvement Make the code longer Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? Needs Testing Need to test it on the guinea pigs (production server) Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't CAS reinforced glass on Sorokyne Strata
5 participants