Skip to content
This repository has been archived by the owner on Oct 17, 2020. It is now read-only.

[Feature] Create admin dashboard for Change logs related queries #612

Open
5 of 6 tasks
rohithbalaji123 opened this issue Mar 31, 2020 · 7 comments
Open
5 of 6 tasks
Assignees
Labels
design-doc Write a design doc for a feature enhancement New feature or request Go Issue requires to write code using Go language p0 High priority React Issue requires knowledge of React framework

Comments

@rohithbalaji123
Copy link
Member

rohithbalaji123 commented Mar 31, 2020

This issue is a start to a bigger issue #347 which concentrates on adding an admin dashboard with a constrained functionalities of supporting CRUD operations related to Change Logs.
This issue will have multiple PRs split in the form of,

  • Design a wireframe for the layout of the admin page (offline, will be updated once finalized).
  • Design [reusable] React components for the purpose.
  • Implement the UI with dummy data.
  • Build authorizer to handle admin authorizations.
  • Add CRUD GraphQL APIs for change logs (C and R already covered in [Feature] Create backend GraphQL APIs for change logs #566 ).
  • Integrate the above functionalities together with actual data.
@rohithbalaji123 rohithbalaji123 added enhancement New feature or request Go Issue requires to write code using Go language React Issue requires knowledge of React framework design-doc Write a design doc for a feature labels Mar 31, 2020
@rohithbalaji123 rohithbalaji123 self-assigned this Mar 31, 2020
@magicoder10
Copy link
Member

@rohithbalaji123 We also need to implementation authorizer to handle permissions: https://martinfowler.com/articles/web-security-basics.html#AuthorizeActions

@magicoder10
Copy link
Member

magicoder10 commented Apr 1, 2020

For your information, I am refactoring authenticator: #611
This is just a prototype. Will split into small PRs and clean up.

@rohithbalaji123
Copy link
Member Author

@byliuyang
Okay, updated the issue.
Also, I guess, we would need a separate login page for admin site. Having a modal like in main site doesn't look completely secure for admin actions. What are your thoughts?

@magicoder10
Copy link
Member

magicoder10 commented Apr 1, 2020

@rohithbalaji123 I saw some critical large scale system sharing the same sign in page. However, I do see them having two factor authentication. We may want to force 2-factor authentication for admin accounts.

@JackieYJC JackieYJC added the p1 Medium priority label Apr 5, 2020
@magicoder10 magicoder10 added p0 High priority and removed p1 Medium priority labels Apr 8, 2020
@magicoder10
Copy link
Member

Here is template prototype I made: #651
Need your help to clean it up and productionize the code.

@magicoder10
Copy link
Member

Changelog Screen

@magicoder10
Copy link
Member

Changelog Screen - Create Change

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design-doc Write a design doc for a feature enhancement New feature or request Go Issue requires to write code using Go language p0 High priority React Issue requires knowledge of React framework
Projects
None yet
Development

No branches or pull requests

3 participants