Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking issue] Silent retirement of maintainers #290642

Closed
AndersonTorres opened this issue Feb 22, 2024 · 10 comments
Closed

[Tracking issue] Silent retirement of maintainers #290642

AndersonTorres opened this issue Feb 22, 2024 · 10 comments
Labels
5. scope: tracking Long-lived issue tracking long-term fixes or multiple sub-problems

Comments

@AndersonTorres
Copy link
Member

AndersonTorres commented Feb 22, 2024

There are many maintainers that didn't touch Nixpkgs in a long span of time.
They should be listed, formally retired and their packages put to adoption.

Edit: here are some I have found while reading the PR list:

#290642 (comment)

@emilylange
Copy link
Member

We have RFC 55 (and it's amendment RFC 71) for committers already.

It's current tracking issue is #88867 and has been so since 2020.

Is this what you mean or are you specifically trying to target contributors which are not committers?

@AndersonTorres
Copy link
Member Author

AndersonTorres commented Feb 22, 2024

Independent of commit bit. There are many phantom contribs.

@Sigmanificient
Copy link
Member

Having a dedicated tag for package adoption would be very nice:

@AndersonTorres
Copy link
Member Author

AndersonTorres commented May 11, 2024

I am cogitating another idea: mark them as inactive at maintainer-list. Abandoned idea.

@AndersonTorres
Copy link
Member Author

AndersonTorres commented Jun 4, 2024

(deleted since the issue was closed)

@AndersonTorres AndersonTorres changed the title [Tracking issue] Soft retirement of maintainers [Tracking issue] Silent retirement of maintainers Jul 15, 2024
shahinism pushed a commit to shahinism/nixpkgs that referenced this issue Jul 15, 2024
Tracking issue: NixOS#290642

Inactive since at least 2017 and 2022 respectively.
shahinism pushed a commit to shahinism/nixpkgs that referenced this issue Jul 15, 2024
shahinism pushed a commit to shahinism/nixpkgs that referenced this issue Jul 15, 2024
Tracking issue: NixOS#290642

Inactive since at least 2017 and 2022 respectively.
fpletz added a commit to fpletz/nixpkgs that referenced this issue Jul 21, 2024
Inactive over a long time. NixOS#290642

Co-authored-by: Anderson Torres <[email protected]>
@AndersonTorres
Copy link
Member Author

Closing because of events in #337478

@AndersonTorres AndersonTorres closed this as not planned Won't fix, can't repro, duplicate, stale Aug 26, 2024
@SigmaSquadron
Copy link
Contributor

SigmaSquadron commented Aug 26, 2024

I feel like while this issue should remain closed, another should be opened for community consultation on inactive maintainers. Something like #331085, where the arguments for and against are organised in the top-level comment.

@Mic92
Copy link
Member

Mic92 commented Aug 26, 2024

I am still interested in an RFC that also removes inactive maintainers. It helps to decided what packages are unmaintained and which can ultimately removed from nixpkgs.
Of course the person that is inactive should be informed with a reasonable time to respond.
The reason is that more package means more work for others i.e. when doing refactoring or bumping dependencies.
In nixpkgs we make it easy to add packages, therefore it shouldn't be harder to remove packages. Nixpkgs should not just be a dumping ground, if people don't have time to maintain their stuff, we rather not should have these packages.
When it comes to pinging former maintainers, there is also a "blame" and "log" view for every package that can be used even if no current maintainer is assigned. Github often suggest candidates to ping or review when making a pull request.

@bendlas
Copy link
Contributor

bendlas commented Aug 26, 2024

I am still interested in an RFC that also removes inactive maintainers

Why not just give them an active = false; flag? Or better yet a lastActive = "2020-02-02";? This would help with the same goal of deciding maintenance status, while retaining multiple advantages over outright deleting them:

  • It doesn't look like we're erasing their contribution mark, while keeping the fruits of their labor
  • It gives them a carrot (do this to get your active status back) instead of a stick (you're gone now)
  • They might still be responding to specific questions, but not really doing code reviews or giving tutorials

Also: as part of any follow-up initiative, I'd like to see a very clear definition of what constitutes "activity", as well as the time frame that we're expecting people to engage within, in order to retain their active status.

@AndersonTorres
Copy link
Member Author

Here is the issue about marking long term inactivity:

#310759

Feel free to rehash the issues already discussed and found wanting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5. scope: tracking Long-lived issue tracking long-term fixes or multiple sub-problems
Projects
None yet
Development

No branches or pull requests

7 participants